-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix order in which fingerprints are evaluated #415
Conversation
this needs to be done on the key generated from the provider, not at the start
@michaeljguarino This solution also doesn't work. We still compare two different encryption keys. The SHA is generated from |
Also |
This should extract the key from the crypto provider, in the case of sharing that will be the key decrypted from w/in |
@zreigz fixed the bug with latest commit |
3b13004
to
0c67b3b
Compare
0c67b3b
to
d6400c6
Compare
@michaeljguarino I have fixed a few issues and tested it again. Adde e2e test for repo sharing passed. PTAL and we can merge it |
@zreigz lgtm (can't approve though since it's my PR i think) |
* Fix order in which fingerprints are evaluated this needs to be done on the key generated from the provider, not at the start * need to base32 encode instead of base64 * fix when .keyid doesn't exist * fix error handling --------- Co-authored-by: Lukasz Zajaczkowski <zreigz@gmail.com>
Summary
this needs to be done on the key generated from the provider, not at the start
Test Plan
tbd
Checklist