Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup finalizers for all namespace resources #421

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zreigz
Copy link
Member

@zreigz zreigz commented Jul 4, 2023

Summary

Don't force destroy namespaces during plural destroy.
The new implementation search for all namespaced resource types and then remove finalizers for the remaining objects in the namespace.

Labels

Test Plan

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@zreigz zreigz added the enhancement New feature or request label Jul 4, 2023
Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we confirm this is effective? I do want us to be sure we can do full destroys without issue as consistently as possible, since not being able to tear down a cluster you no longer want is no bueno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants