Updated in-app pricing page for CD #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swoodward90
added
frontend
michaeljguarino
approved these changes
Nov 13, 2023
| checked: true, | ||
| }, | ||
| { | ||
| label: '1 cluster', |
There was a problem hiding this comment.
we can put this but the enforcement is going to be honor system on the cluster side
|
Visit the preview URL for this PR (updated for commit 20c0d51): https://pluralsh--pr1273-swoodward-cd-pricing-ip7bmjx6.web.app (expires Mon, 20 Nov 2023 20:43:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 16a5e8ed11dae87f435fa6b87804553fe417305e |
swoodward90
commented
Nov 13, 2023
| @@ -174,6 +182,10 @@ function BillingPricingTable() { | |||
| <Div body2>Unlimited</Div> | |||
| <Div body2>${clusterMonthlyPricing}/cluster/month</Div> | |||
| <Div body2>${userMonthlyPricing}/user/month</Div> | |||
| <Div body2>$200/pack of 5 services/month</Div> | |||
There was a problem hiding this comment.
@michaeljguarino hard-coding this for now since I think we'll need the variable for service monthly pricing - TODO fix
There was a problem hiding this comment.
that's ok yea it's not exposed in the api now (and it's not exactly a line-item due to weirdness w/ usage based billing as well)
michaeljguarino
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Labels
Test Plan
Checklist