Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud setup flow #1351

Merged
merged 17 commits into from
Sep 9, 2024
Merged

cloud setup flow #1351

merged 17 commits into from
Sep 9, 2024

Conversation

jsladerman
Copy link
Contributor

adds ui for cloud-hosted console

@jsladerman jsladerman added enhancement New feature or request frontend Changes related to the frontend labels Aug 27, 2024
@jsladerman jsladerman requested a review from a team August 27, 2024 23:46
Copy link

linear bot commented Aug 27, 2024

@jsladerman jsladerman force-pushed the jake/prod-2569-cloud-setup-flow branch from b99da83 to 8326dd4 Compare August 28, 2024 04:22
@jsladerman jsladerman force-pushed the jake/prod-2569-cloud-setup-flow branch 2 times, most recently from e5517d2 to 14b1bca Compare August 28, 2024 20:35
@jsladerman jsladerman force-pushed the jake/prod-2569-cloud-setup-flow branch from 14b1bca to 1501e6b Compare August 28, 2024 20:36
@jsladerman jsladerman force-pushed the jake/prod-2569-cloud-setup-flow branch from d91b97f to f9da946 Compare August 29, 2024 03:56
@jsladerman jsladerman marked this pull request as ready for review September 5, 2024 05:40
@jsladerman jsladerman force-pushed the jake/prod-2569-cloud-setup-flow branch from 54ab846 to 2397fba Compare September 5, 2024 06:04
@floreks
Copy link
Member

floreks commented Sep 5, 2024

Quickly went through the screens to do some VQA based on the figma design. Is it the latest design? I am seeing some differences that seem intentional.

General

  • The OIDC dialog seems only to update cluster-level permissions. I do not see a way to grant console access to the user in the plural app.

Install Plural CLI

Current

image

Spec

image

Deploy Yourself Path

I didn't see the Your cluster was successfully deployed! toast after completing it.
image

Use Plural Cloud Path

  • I am not seeing the free trial user notification

Current

image

Spec

image

  • Navigating out of the cloud instance creation view after it has started creating the cloud console in the background does not trigger any warning dialog. There is no way to get back and resume afterward. I imagine that API still creates it in background.
  • I am not able to access the cloud console
    image

@floreks
Copy link
Member

floreks commented Sep 6, 2024

Zerostate for the self-hosted clusters is empty.

image

We can either:

  • auto-switch to cloud instances tab if it is empty
  • add a zerostate (empty table or something)

Trying to access Edit cluster managers dialog when console is in pending state fails

image

It is due to SA being undefined. Probably because instance is not yet fully provisioned.
image

Trying to access console now fails due to redirectUris not being configured for the OIDC provider.

image

It might be best to add this field, similar to the console edit oidc view. Our main app.plural.sh should be configured by default. I am not sure why it isn't. Maybe the mutation that updates the user, deletes previously configured redirectUris?

@jsladerman
Copy link
Contributor Author

Zerostate for the self-hosted clusters is empty.

image

We can either:

  • auto-switch to cloud instances tab if it is empty
  • add a zerostate (empty table or something)

Trying to access Edit cluster managers dialog when console is in pending state fails

image

It is due to SA being undefined. Probably because instance is not yet fully provisioned. image

Trying to access console now fails due to redirectUris not being configured for the OIDC provider.

image

It might be best to add this field, similar to the console edit oidc view. Our main app.plural.sh should be configured by default. I am not sure why it isn't. Maybe the mutation that updates the user, deletes previously configured redirectUris?

addressed all these in latest commit

@jsladerman jsladerman force-pushed the jake/prod-2569-cloud-setup-flow branch from e0703d8 to 37cd0c5 Compare September 6, 2024 17:32
@jsladerman jsladerman force-pushed the jake/prod-2569-cloud-setup-flow branch 2 times, most recently from d075f1a to 6f6607c Compare September 6, 2024 22:50
@jsladerman jsladerman force-pushed the jake/prod-2569-cloud-setup-flow branch from 6f6607c to ee1e252 Compare September 8, 2024 19:20
@floreks
Copy link
Member

floreks commented Sep 9, 2024

I retested everything and haven't found any issues. Everything works smoothly now. Looks great!

@jsladerman jsladerman force-pushed the jake/prod-2569-cloud-setup-flow branch from 12c10d4 to e5cbd42 Compare September 9, 2024 21:13
@jsladerman jsladerman merged commit 6108826 into master Sep 9, 2024
8 checks passed
@jsladerman jsladerman deleted the jake/prod-2569-cloud-setup-flow branch September 9, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Changes related to the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants