Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console sideload url format #1354

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Console sideload url format #1354

merged 1 commit into from
Aug 29, 2024

Conversation

michaeljguarino
Copy link
Member

Need to prefix with https:// since that's what the console sends back to bootstrap the cluster record

Also bumped absinthe to potentially fix graphiql being goofy

Test Plan

existing tests

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@michaeljguarino michaeljguarino added the enhancement New feature or request label Aug 29, 2024
@michaeljguarino michaeljguarino requested a review from a team August 29, 2024 20:11
Need to prefix with https:// since that's what the console sends back to bootstrap the cluster record

Also bumped absinthe to potentially fix graphiql being goofy
Copy link

stoat-app bot commented Aug 29, 2024

Easy and customizable dashboards for your build system. Learn more about Stoat ↗︎

Static Hosting

Name Link Commit Status
api-coverage Visit b5fee07
rtc-coverage Visit b5fee07
core-coverage Visit b5fee07
cron-coverage Visit b5fee07
email-coverage Visit b5fee07
worker-coverage Visit b5fee07
api-test-results Visit b5fee07
graphql-coverage Visit b5fee07
rtc-test-results Visit b5fee07
core-test-results Visit b5fee07
cron-test-results Visit b5fee07
email-test-results Visit b5fee07
worker-test-results Visit b5fee07
graphql-test-results Visit b5fee07

Job Runtime

job runtime chart

debug

@michaeljguarino michaeljguarino merged commit b4a1f29 into master Aug 29, 2024
10 checks passed
@michaeljguarino michaeljguarino deleted the fix-console-sideload branch August 29, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants