Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query DNS before finalizing cloud instances #1357

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Conversation

michaeljguarino
Copy link
Member

There's some lag to externaldns registering for an ingress that could cause user-facing goofiness, just query dns until it resolves to wait for that to dissipate.

Test Plan

existing test still works

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

There's some lag to externaldns registering for an ingress that could cause user-facing goofiness, just query dns until it resolves to wait for that to dissipate.
@michaeljguarino michaeljguarino added the enhancement New feature or request label Aug 30, 2024
@michaeljguarino michaeljguarino requested a review from a team August 30, 2024 21:09
Copy link

stoat-app bot commented Aug 30, 2024

Easy and customizable dashboards for your build system. Learn more about Stoat ↗︎

Static Hosting

Name Link Commit Status
api-coverage Visit 05805bb
rtc-coverage Visit 05805bb
core-coverage Visit 05805bb
cron-coverage Visit 05805bb
email-coverage Visit 05805bb
worker-coverage Visit 05805bb
api-test-results Visit 05805bb
graphql-coverage Visit 05805bb
rtc-test-results Visit 05805bb
core-test-results Visit 05805bb
cron-test-results Visit 05805bb
email-test-results Visit 05805bb
worker-test-results Visit 05805bb
graphql-test-results Visit 05805bb

Job Runtime

job runtime chart

debug

@michaeljguarino michaeljguarino merged commit 3dd9931 into master Aug 31, 2024
11 checks passed
@michaeljguarino michaeljguarino deleted the test-dns-cloud branch August 31, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants