Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sso login #1361

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fix sso login #1361

merged 1 commit into from
Sep 18, 2024

Conversation

michaeljguarino
Copy link
Member

The login method validation technically fails for SSO (which means us lol). We can trust that login source better than other 3p auth providers so don't validate login method there.

Test Plan

unit test

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@michaeljguarino michaeljguarino added the enhancement New feature or request label Sep 17, 2024
@michaeljguarino michaeljguarino requested a review from a team September 17, 2024 04:01
Copy link

stoat-app bot commented Sep 17, 2024

Easy and customizable dashboards for your build system. Learn more about Stoat ↗︎

Static Hosting

Name Link Commit Status
api-coverage Visit fe520b1
rtc-coverage Visit fe520b1
core-coverage Visit fe520b1
cron-coverage Visit fe520b1
email-coverage Visit fe520b1
worker-coverage Visit fe520b1
api-test-results Visit fe520b1
graphql-coverage Visit fe520b1
rtc-test-results Visit fe520b1
core-test-results Visit fe520b1
cron-test-results Visit fe520b1
email-test-results Visit fe520b1
worker-test-results Visit fe520b1
graphql-test-results Visit fe520b1

Job Runtime

job runtime chart

debug

The login method validation technically fails for SSO (which means us lol).  We can trust that login source better than other 3p
auth providers so don't validate login method there.
@michaeljguarino michaeljguarino merged commit 4566e48 into master Sep 18, 2024
10 checks passed
@michaeljguarino michaeljguarino deleted the fix-sso-logins branch September 18, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants