Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement top bar #210

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Implement top bar #210

merged 3 commits into from
Apr 21, 2022

Conversation

dherault
Copy link
Contributor

image

@dherault dherault self-assigned this Apr 20, 2022
@dherault dherault added the enhancement New feature or request label Apr 20, 2022
@dherault
Copy link
Contributor Author

Please wait for pluralsh/design-system#22 to be merged before reviewing.

michaeljguarino
michaeljguarino reviewed Apr 20, 2022
View reviewed changes
Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fix that's not your fault, just a bit of lag on changing the design based on some of my feedback

www/src/components/repos/SearchRepositories.js Outdated
@@ -49,6 +41,7 @@ export default function SearchRepositories() {
type="search"
value={value}
name="search"
icon={<MagnifyingGlassIcon color="text-weak" />}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I was going to mention to the designers, but the backslash search icon is a bit nicer for us than the plain glass icon, and I've seen a lot of dev-y products start using it. I think we should keep it.

@dherault dherault merged commit 95b43ec into www2 Apr 21, 2022
@dherault dherault deleted the implement-top-bar branch April 21, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljguarino michaeljguarino michaeljguarino left review comments

Assignees

@dherault dherault

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dherault @michaeljguarino