Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-Infer git user via oauth information #227

Merged
merged 1 commit into from
May 11, 2022
Merged

Auto-Infer git user via oauth information #227

merged 1 commit into from
May 11, 2022

Conversation

michaeljguarino
Copy link
Member

@michaeljguarino michaeljguarino commented May 11, 2022 •
edited
Loading

Summary

We technically get git user/email during the oauth handshake, so we can auto fill those in your console configuration if you've already oauthed.

Test Plan

Added unit test

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

Fixes PLU-25

@michaeljguarino
Auto-Infer git user via oauth information
919eca7 
We technically get git user/email during the oauth handshake, so we can auto fill those in your console configuration if you've already oauthed.
@michaeljguarino michaeljguarino added the enhancement New feature or request label May 11, 2022
@michaeljguarino michaeljguarino merged commit 3890dd0 into master May 11, 2022
@michaeljguarino michaeljguarino deleted the shell-git-oauth branch May 11, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidspek davidspek Awaiting requested review from davidspek

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michaeljguarino