Add Shell SCM Support for Gitlab #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljguarino
force-pushed
the
gitlab-scm
branch
from
0a71b7b
to
5e9fb2f
Compare
This implements the scm provider for cloud shell against the gitlab api, using our oauth client similarly to with github
michaeljguarino
force-pushed
the
gitlab-scm
branch
from
5e9fb2f
to
0303f8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This implements the scm provider using our gitlab oauth client. It's largely an imitation of the existing github provider, tweaking api reqs/responses
Test Plan
add/tweak unit tests, will also integration test once merged and working on frontend
Checklist
Fixes PLU-40