Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hydra: add offline_access scope for refresh tokens #273

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

davidspek
Copy link
Contributor

Summary

Currently the Plural OIDC provider does not support returning refresh tokens. This PR adds the offline_access scope to OIDC clients when they are created, as well as too the app consent following https://www.ory.sh/docs/hydra/debug#oauth-20-refresh-token-is-missing.

Test Plan

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

Signed-off-by: DavidSpek <vanderspek.david@gmail.com>
@davidspek davidspek added enhancement New feature or request bug-fix This pull request fixes a bug labels Jun 28, 2022
Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess is the apps need to be configured to request these scopes as well, but let's try it. We should hold off until merging until night time EST to minimize issues if it breaks something though.

@davidspek
Copy link
Contributor Author

@michaeljguarino Indeed the apps need to be configured to request the scopes, but they currently can't because the scope is not enabled for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This pull request fixes a bug enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants