Fix Marketplace #275
Merged
Fix Marketplace #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dherault
added
design
| <Table | ||
| headers={['Name', 'Description', 'Last Updated', 'Status']} | ||
| sizes={['25%', '25%', '25%', '25%']} | ||
| background="fill-one" | ||
| width="100%" | ||
| height="100%" | ||
| height="calc(100% - 16px - 16px - 53px)" // The previous node is 53px tall with a 16px marginBottom |
There was a problem hiding this comment.
Wouldn't it be easier to put this in a 100%x100% box with 16px vertical padding?
There was a problem hiding this comment.
Does work with flex layouts IMO, but if you know better please commit coz I ain't fighting this battle again.
michaeljguarino
approved these changes
Jun 28, 2022
| if (!data || !cluster) return <LoopingLogo /> | ||
| if (!data || !cluster) { | ||
| return ( | ||
| <Flex |
There was a problem hiding this comment.
could we make this a separate function for cleanliness?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Quick fixes for almost every screen of the app:
Labels
Test Plan
Checklist