Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Firebase hosting for plural #411

Merged
merged 6 commits into from
Aug 9, 2022
Merged

Conversation

michaeljguarino
Copy link
Member

Summary

Should provide support for pr-based preview envs

Test Plan

creating this pr

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

Should provide support for pr-based preview envs
@michaeljguarino michaeljguarino added enhancement New feature or request frontend Changes related to the frontend labels Aug 9, 2022
@michaeljguarino michaeljguarino requested review from dherault and a team August 9, 2022 17:25
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

Visit the preview URL for this PR (updated for commit 700090a):

https://pluralsh--pr411-add-firebase-actions-if3o683o.web.app

(expires Tue, 16 Aug 2022 19:45:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@michaeljguarino michaeljguarino merged commit 2eb8fcc into master Aug 9, 2022
@michaeljguarino michaeljguarino deleted the add-firebase-actions branch August 9, 2022 20:47
@dherault dherault restored the add-firebase-actions branch August 9, 2022 21:30
@dherault dherault deleted the add-firebase-actions branch August 9, 2022 21:32
@dherault
Copy link
Contributor

dherault commented Aug 9, 2022

I merged this one into #381 for direct use

@maciaszczykm
Copy link
Member

In this case we can keep merging master to keep packages-redesign up to date to avoid solving same conflicts twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Changes related to the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants