Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close InstallDropdown on outside click #455

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

dherault
Copy link
Contributor

Just had to fix it in honorable.

image

Summary

Labels

Test Plan

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@dherault dherault added design Any design-related changes bug-fix This pull request fixes a bug labels Aug 24, 2022
@dherault dherault self-assigned this Aug 24, 2022
@dherault dherault requested a review from a team as a code owner August 24, 2022 09:38
@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2022

Visit the preview URL for this PR (updated for commit 8484391):

https://pluralsh--pr455-davidh-eng-527-dropd-g9w71nys.web.app

(expires Wed, 31 Aug 2022 16:14:55 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@dherault dherault merged commit db3dd47 into master Aug 24, 2022
@dherault dherault deleted the davidh/eng-527-dropdown-interaction branch August 24, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This pull request fixes a bug design Any design-related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants