Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email helper module #460

Merged
merged 11 commits into from
Sep 6, 2022
Merged

Conversation

michaeljguarino
Copy link
Member

@michaeljguarino michaeljguarino commented Aug 24, 2022

Summary

Adds a few functions that can be called from iex to send emails for testing.

David H:
Adds new email designs:
image

Resolves ENG-422

Test Plan

n/a

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

Adds a few functions that can be called from iex to send emails for testing.
@michaeljguarino michaeljguarino added the backend Changes related to the backend label Aug 24, 2022
@michaeljguarino michaeljguarino requested review from dherault and a team August 24, 2022 17:56
@dherault
Copy link
Contributor

Please do not merge, I'll include the updated emails on top of this one.

Adds a few functions that can be called from iex to send emails for testing.
@michaeljguarino michaeljguarino force-pushed the mjg/eng-542-email-test-helper-module branch from 2a53de3 to ada10a2 Compare August 24, 2022 19:04
@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2022

Visit the preview URL for this PR (updated for commit 736c3f3):

https://pluralsh--pr460-mjg-eng-542-email-te-dm9i1pha.web.app

(expires Mon, 05 Sep 2022 11:46:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@dherault
Copy link
Contributor

Ready to review.

@dherault
Copy link
Contributor

We'll need a way to test if these new emails are formatted properly in many browser/clients.

@davidspek davidspek added the enhancement New feature or request label Aug 30, 2022
@michaeljguarino michaeljguarino merged commit b1dde22 into master Sep 6, 2022
@michaeljguarino michaeljguarino deleted the mjg/eng-542-email-test-helper-module branch September 6, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Changes related to the backend enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

3 participants