Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-549 Account Refinements - Account attributes #461

Merged
merged 21 commits into from
Aug 29, 2022
Merged

ENG-549 Account Refinements - Account attributes #461

merged 21 commits into from
Aug 29, 2022

Conversation

dogmar
Copy link
Collaborator

@dogmar dogmar commented Aug 24, 2022 •
edited
Loading

Part 1 of updating all the Account pages.
Linear
Linear parent issue
Figma

Screen Shot 2022-08-24 at 4 00 12 PM 1

@dogmar dogmar requested a review from a team as a code owner August 24, 2022 22:58
@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2022 •
edited
Loading

Visit the preview URL for this PR (updated for commit b794e59):

https://pluralsh--pr461-klink-eng-549-accoun-pax3keqi.web.app

(expires Mon, 05 Sep 2022 16:09:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@michaeljguarino
Copy link
Member

At looks like Account Attributes is the last in the list of tabs in the gutter, but it should actually be the first element

floreks
floreks reviewed Aug 25, 2022
View reviewed changes
www/src/components/profile/Icon.tsx
hover?: string
}

export const Icon = forwardRef<HTMLDivElement, IconProps>(({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a DS component candidate.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure I can pull that out into the design system once this is all done.

@dogmar
Copy link
Collaborator Author

dogmar commented Aug 25, 2022

At looks like Account Attributes is the last in the list of tabs in the gutter, but it should actually be the first element

@michaeljguarino Looks like I bet on the wrong horse regarding this request: "Either default selection to account settings or switch order of tabs."
I've restored the tab order and now the page defaults to the "Account attributes" tab.

@dogmar
Implement size variants for Icon
f83e673 
This will eventually be moved to design system
@dogmar dogmar force-pushed the klink/eng-549-account-refinement-account-attributes branch from 43ef71f to f83e673 Compare August 25, 2022 19:28
maciaszczykm
maciaszczykm approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@maciaszczykm maciaszczykm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

dherault
dherault approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@dherault dherault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidspek davidspek added the enhancement New feature or request label Aug 29, 2022
@dogmar
Merge remote-tracking branch 'origin/master' into klink/eng-549-accou…
c291d80 
…nt-refinement-account-attributes

# Conflicts:
#	www/src/components/account/Groups.js
#	www/src/components/account/MoreMenu.js
#	www/src/components/account/Roles.js
#	www/src/components/account/ServiceAccounts.js
@dogmar dogmar force-pushed the klink/eng-549-account-refinement-account-attributes branch from 0e18a6c to c291d80 Compare August 29, 2022 16:00
@dogmar
Remove unused component
b794e59 
Now imported from design system as PageTitle
@dogmar dogmar changed the title ENG-308 Account Refinements - Account attributes ENG-549 Account Refinements - Account attributes Aug 29, 2022
@dogmar dogmar merged commit 7b999db into master Aug 29, 2022
@dogmar dogmar deleted the klink/eng-549-account-refinement-account-attributes branch September 29, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dherault dherault dherault approved these changes

@maciaszczykm maciaszczykm maciaszczykm approved these changes

@nickcernera nickcernera Awaiting requested review from nickcernera

@floreks floreks Awaiting requested review from floreks

@michaeljguarino michaeljguarino Awaiting requested review from michaeljguarino

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dogmar @michaeljguarino @floreks @maciaszczykm @dherault @davidspek