Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap e2e #485

Merged
merged 8 commits into from
Sep 12, 2022
Merged

Bootstrap e2e #485

merged 8 commits into from
Sep 12, 2022

Conversation

floreks
Copy link
Member

@floreks floreks commented Aug 30, 2022 •
edited
Loading

Summary

  • setup initial e2e
  • add simple e2e story
  • add GitHub action to run e2e

Test Plan

Start app in dev mode first with yarn start and then go to the e2e directory and yarn e2e:start

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@floreks floreks requested a review from a team as a code owner August 30, 2022 08:32
@floreks floreks added enhancement New feature or request frontend Changes related to the frontend labels Aug 30, 2022
maciaszczykm
maciaszczykm approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@maciaszczykm maciaszczykm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, preview is failing in all PRs as we have reached some limit.

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 90d6d22):

https://pluralsh--pr485-setup-e2e-555ewyek.web.app

(expires Wed, 07 Sep 2022 10:24:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@maciaszczykm
Copy link
Member

@floreks CI is green, can we merge?

@floreks floreks merged commit 7e622a7 into master Sep 12, 2022
@floreks floreks deleted the setup-e2e branch September 12, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciaszczykm maciaszczykm maciaszczykm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request frontend Changes related to the frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@floreks @maciaszczykm