Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-714] [ENG-695] [ENG-718] Add padding to the onboarding sidenav and hide publishers filter #577

Merged

Conversation

floreks
Copy link
Member

@floreks floreks commented Sep 29, 2022

Summary

Fixes ENG-714 & ENG-695 & ENG-718 | Figma

  • Changed plural watch message to plural watch <appName>
  • Updated booting into shell message
    image

ENG-718

  • Slightly updated the message to not suggest that the console was installed when it wasn't
  • Fixed default airbyte install command as it had a typo (airbye) and could not be copied and reused
  • Fixed an issue where I've seen a message to install console for console-aws and airbyte-gcp with different providers.
  • Fixed the retrieveConsole as it was using wrong local storage key. PROVIDER_LOCAL_STORAGE_KEY instead of CONSOLE_LOCAL_STORAGE_KEY
    Zrzut ekranu z 2022-09-29 10-58-39

Zrzut ekranu z 2022-09-29 10-59-21

Test Plan

Locally

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@floreks floreks added bug-fix This pull request fixes a bug frontend Changes related to the frontend labels Sep 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2022

Visit the preview URL for this PR (updated for commit 8309e49):

https://pluralsh--pr577-sebastian-eng-695-pu-z4iyya92.web.app

(expires Fri, 07 Oct 2022 09:57:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@floreks floreks changed the title [ENG-714] [ENG-695] Add padding to the onboarding sidenav and hide publishers filter [ENG-714] [ENG-695] [ENG-718] Add padding to the onboarding sidenav and hide publishers filter Sep 29, 2022
@floreks floreks requested a review from a team September 29, 2022 09:06
@@ -473,7 +506,7 @@ function Step3() {
<CodeLine marginTop="medium">
plural deploy --commit "your message"
</CodeLine>
<P
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed some P to Div as it was giving an error in the console since div cannot be a child of p.

@floreks floreks added enhancement New feature or request and removed enhancement New feature or request labels Sep 29, 2022
@floreks floreks self-assigned this Sep 29, 2022
Copy link
Member

@maciaszczykm maciaszczykm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@floreks floreks merged commit e86e3a1 into master Sep 30, 2022
@floreks floreks deleted the sebastian/eng-695-publishers-filter-should-be-temporarily branch September 30, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This pull request fixes a bug frontend Changes related to the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants