-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-714] [ENG-695] [ENG-718] Add padding to the onboarding sidenav and hide publishers filter #577
[ENG-714] [ENG-695] [ENG-718] Add padding to the onboarding sidenav and hide publishers filter #577
Conversation
Visit the preview URL for this PR (updated for commit 8309e49): https://pluralsh--pr577-sebastian-eng-695-pu-z4iyya92.web.app (expires Fri, 07 Oct 2022 09:57:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
@@ -473,7 +506,7 @@ function Step3() { | |||
<CodeLine marginTop="medium"> | |||
plural deploy --commit "your message" | |||
</CodeLine> | |||
<P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed some P
to Div
as it was giving an error in the console since div
cannot be a child of p
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
…ublishers-filter-should-be-temporarily
Summary
Fixes ENG-714 & ENG-695 & ENG-718 | Figma
plural watch
message toplural watch <appName>
ENG-718
airbye
) and could not be copied and reusedconsole-aws
andairbyte-gcp
with different providers.retrieveConsole
as it was using wrong local storage key.PROVIDER_LOCAL_STORAGE_KEY
instead ofCONSOLE_LOCAL_STORAGE_KEY
Test Plan
Locally
Checklist