ENG-750 - CLI copy code block is appending incorrect code #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogmar
added
bug-fix
|
Visit the preview URL for this PR (updated for commit 24f6d8a): https://pluralsh--pr593-klink-eng-750-cli-co-qhdymf21.web.app (expires Mon, 10 Oct 2022 23:38:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
michaeljguarino
approved these changes
Oct 3, 2022
maciaszczykm
reviewed
Oct 4, 2022
floreks
approved these changes
Oct 4, 2022
@maciaszczykm It's still around in a couple of places, but it's probably a small enough number for one person to tackle replacing them all in a short time. |
|
Sounds good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/pluralsh/issue/ENG-750/cli-copy-code-block-is-appending-incorrect-code
Replaced old CodeLine components with
CodelineandCodefrom the design system. Manually tested the "Copy" buttons, and there is no more extraneous code.