fix: Fix inconsistent result after apply error for cluster tags #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciaszczykm
requested review from
floreks,
michaeljguarino,
seemywingz and
zreigz
…ing-terraform-provider-bug-when-creating-cluster-wo
There was a problem hiding this comment.
Not sure if this solves it, but we should also be able to gracefully handle tags being managed by something else (eg Cluster CRDs). I think currently it might remove tags if an empty map is specified in TF but the CRD adds a few additional.
My expectation would be a null value means terraform ignores that field.
maciaszczykm
commented
Jun 3, 2024
| @@ -56,6 +56,10 @@ type cluster struct { | |||
| // } | |||
|
|
|||
| func (c *cluster) TagsAttribute(ctx context.Context, d diag.Diagnostics) []*console.TagAttributes { | |||
| if c.Tags.IsNull() { | |||
| return nil | |||
| } | |||
There was a problem hiding this comment.
@michaeljguarino I think this should solve the issue you mentioned in the comment above.
michaeljguarino
approved these changes
Jun 3, 2024
michaeljguarino
deleted the
marcin/eng-2117-annoying-terraform-provider-bug-when-creating-cluster-wo
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.