Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add detach attribute to cluster resource #40

Merged
merged 5 commits into from
Jun 13, 2024
Merged

feat: Add detach attribute to cluster resource #40

merged 5 commits into from
Jun 13, 2024

Conversation

maciaszczykm
Copy link
Member

@maciaszczykm maciaszczykm commented Jun 12, 2024 •
edited
Loading

Tested detach, deletion and detach after delete timed out (set it to 15s and it resulted in the warning visible below).

Zrzut ekranu 2024-06-12 o 13 37 47

@linear Linear
Copy link

linear bot commented Jun 12, 2024

PROD-2236 Add `detach` attribute to terraform provider

@maciaszczykm maciaszczykm marked this pull request as ready for review June 12, 2024 11:39
michaeljguarino
michaeljguarino reviewed Jun 13, 2024
View reviewed changes
Copy link
Member

@michaeljguarino michaeljguarino left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that error message might pick up our keyword match at the moment since it includes Error: (oh wait it doesn't have a colon so maybe its ok?)

@michaeljguarino michaeljguarino merged commit 6b54ee0 into main Jun 13, 2024
10 of 11 checks passed
@michaeljguarino michaeljguarino deleted the marcin/prod-2236-add-detach-attribute-to-terraform-provider branch June 13, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljguarino michaeljguarino michaeljguarino approved these changes

@floreks floreks Awaiting requested review from floreks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciaszczykm @michaeljguarino