Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): remove runtime dependency for AWS account ID retrieval #319

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

jianzs
Copy link
Contributor

@jianzs jianzs commented Aug 6, 2024

The previous AWS queue resource type implementation required the AWS_ACCOUNT_ID environment variable to be set by the runtime handler. The setting only occurred upon receiving a request, causing a panic if the queue resource type was used globally without the AWS_ACCOUNT_ID being set.

This commit eliminates the need for runtime setting of AWS_ACCOUNT_ID by utilizing the sts.GetCallerIdentity API to retrieve the account ID.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

  • SDK

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

The previous AWS queue resource type implementation required the `AWS_ACCOUNT_ID` environment variable to be set by the runtime handler. The setting only occurred upon receiving a request, causing a panic if the queue resource type was used globally without the `AWS_ACCOUNT_ID` being set.

This commit eliminates the need for runtime setting of `AWS_ACCOUNT_ID` by utilizing the `sts.GetCallerIdentity` API to retrieve the account ID.
@jianzs jianzs added sdk Client SDK and Infra SDK 💡feature This issue or pull request is related to a new feature. labels Aug 6, 2024
Copy link

changeset-bot bot commented Aug 6, 2024

🦋 Changeset detected

Latest commit: d32f9f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@plutolang/pluto Patch
@plutolang/cli Patch
@plutolang/simulator-adapter Patch
@plutolang/pluto-infra Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jianzs jianzs merged commit cdf966f into pluto-lang:main Aug 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡feature This issue or pull request is related to a new feature. sdk Client SDK and Infra SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant