WIP: lockfile and other issues #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lonerapier I'm leaving this here as is. There are some TODOs left around and in docs. It would be nice to clean up as much as we can and remove TODOs and unnecessary inline comments including in the codegen'd stuff. Please go ahead and feel free to merge this once you're content and go from here so we can continue the grind forward :) |
|
Oh, by the way, you will probably have to |
Closed
lonerapier
force-pushed
the
feat/public-lock
branch
from
ee7b757
to
2bae08b
Compare
fix tests response tests write out the lock used optional logs on extractor renames more refactor codegen extracts http body CLI and doc Create bounty.md Created an ISSUE_TEMPLATE folder with the bounty.md file Update bounty.md Create LICENSE-MIT Create LICENSE-Apache Update README.md (#81) Updated README for consistency with Plonkathon and AES-proof, going to need some help to get it over the line, dependent on name change lots of cleanup place examples in respective dir basic circuit cleanup pending work fix tests
lonerapier
force-pushed
the
feat/public-lock
branch
from
2bae08b
to
55c8b8e
Compare
|
@Autoparallel tests are passing, merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--debugflag to optionally display in-circuit logs #77Other things I did:
extractor.rsandhttp_lock.rstojson.rsandhttp.rsand did the same with the commands.