montgomery arithmetic #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xJepsen
requested changes
May 3, 2024
src/field.rs
Outdated
| // const MONTY_MU: u32 = 80; | ||
| const MONTY_BITS: u32 = 7; | ||
| const MONTY_MASK: u32 = (1 << MONTY_BITS) - 1; | ||
| const MONTY_MU: u32 = 19; // (-P^-1) mod 2^MONTY_BITS |
There was a problem hiding this comment.
Nice work! I think functionally this PR is amazing. My main feedback is i think we should go hard on some comments since we plan to make this a learning resource. If you had to explain to someone what you where doing, who didn't have much prior experience how would you paint the intuition? What intuition made the optimization clique for you? Is there a small example we can include in the comments or another test? Personally i find if i can explain things well it really solidifies my understanding too :)
There was a problem hiding this comment.
@0xJepsen added comments and examples for montgomery and barret reduction. Let me know if those are not clearly explained.
0xJepsen
approved these changes
May 3, 2024
fixed |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #16
closes #17
closes #18
It changes the following: