Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: home-baked FiniteField trait #38

Merged
merged 5 commits into from
May 6, 2024
Merged

feat: home-baked FiniteField trait #38

merged 5 commits into from
May 6, 2024

Conversation

Autoparallel
Copy link
Contributor

This PR gets the following:

  • Restructures field.rs -> field/mod.rs.
  • Creates the FiniteField trait in field/mod.rs.
  • Renames PlutoField to GF101 and implements FiniteField on it.

Closes #27

@Autoparallel
feat: new FiniteField trait
740e0c6 
Now everything compiles again. Will work to clean this all up and get all the tests to pass.
@Autoparallel
fix: GF101 tests pass
6629016
@Autoparallel
fix: reimplement monty optimizations
034ef34
@Autoparallel
clean: udeps
2f28f92
@Autoparallel
Copy link
Contributor Author

We could probably streamline this trait a lot as only the generator() method is really something that depends on the field in a way that needs outside computing.

0xJepsen
0xJepsen approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xJepsen 0xJepsen merged commit d1c84eb into main May 6, 2024
2 of 4 checks passed
@0xJepsen 0xJepsen deleted the feat/field-trait branch May 6, 2024 23:39
Autoparallel added a commit that referenced this pull request May 7, 2024
@Autoparallel
Squashed commit of the following:
b66eac4 
commit f9aa66e
Author: Waylon Jepsen <57912727+0xJepsen@users.noreply.github.com>
Date:   Tue May 7 09:00:35 2024 -0600

    curves in sage (#39)

commit 63ce62f
Author: Waylon Jepsen <waylonjepsen1@gmail.com>
Date:   Mon May 6 17:46:22 2024 -0600

    fix: lock

commit d1c84eb
Author: Colin Roberts <colin@autoparallel.xyz>
Date:   Mon May 6 16:39:25 2024 -0700

    feat: home-baked `FiniteField` trait (#38)

    * feat: new `FiniteField` trait

    Now everything compiles again. Will work to clean this all up and get all the tests to pass.

    * fix: `GF101` tests pass

    * fix: reimplement monty optimizations

    * clean: udeps

    ---------

    Co-authored-by: Waylon Jepsen <57912727+0xJepsen@users.noreply.github.com>

commit 96c8b66
Merge: fb27e5f 62a9a57
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Mon May 6 23:26:56 2024 +0000

    Merge pull request #42 from pluto/dependabot/cargo/anyhow-1.0.83

    Bump anyhow from 1.0.82 to 1.0.83

commit 62a9a57
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon May 6 23:26:43 2024 +0000

    Bump anyhow from 1.0.82 to 1.0.83

    Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.82 to 1.0.83.
    - [Release notes](https://github.com/dtolnay/anyhow/releases)
    - [Commits](dtolnay/anyhow@1.0.82...1.0.83)

    ---
    updated-dependencies:
    - dependency-name: anyhow
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
Autoparallel added a commit that referenced this pull request May 9, 2024
@Autoparallel
Squashed commit of the following:
2fbd9c5 
commit 2637594
Author: Waylon Jepsen <57912727+0xJepsen@users.noreply.github.com>
Date:   Thu May 9 10:38:12 2024 -0600

    curves: Second curve group and some test (#49)

    * chore: tests + scalar multiplication

    * fmt

    * wip: compiles, but generator point is broken

    * wip

    * fix mul, generator and add hardcoded tests (#51)

    * fix mul, generator and add hardcoded tests

    * fix generator test

    * wip

    * fix: test fails when rng has no inverse

    ---------

    Co-authored-by: Sambhav <lonerapier@proton.me>

commit def9371
Author: Waylon Jepsen <57912727+0xJepsen@users.noreply.github.com>
Date:   Thu May 9 09:36:25 2024 -0600

    docs: readme (#46)

    * docs: readme

    * wip: pairing check

    * docs

    * Update README.md

    Co-authored-by: Colin Roberts <colin@autoparallel.xyz>

    * Update README.md

    Co-authored-by: Colin Roberts <colin@autoparallel.xyz>

    ---------

    Co-authored-by: Colin Roberts <colin@autoparallel.xyz>

commit ab0d374
Author: Sambhav <lonerapier@proton.me>
Date:   Wed May 8 03:00:15 2024 +0530

    Extension field (#44)

    * feat: extension field init

    * add test

    * add more tests and comments

    * move pow impl default to trait

commit f9aa66e
Author: Waylon Jepsen <57912727+0xJepsen@users.noreply.github.com>
Date:   Tue May 7 09:00:35 2024 -0600

    curves in sage (#39)

commit 63ce62f
Author: Waylon Jepsen <waylonjepsen1@gmail.com>
Date:   Mon May 6 17:46:22 2024 -0600

    fix: lock

commit d1c84eb
Author: Colin Roberts <colin@autoparallel.xyz>
Date:   Mon May 6 16:39:25 2024 -0700

    feat: home-baked `FiniteField` trait (#38)

    * feat: new `FiniteField` trait

    Now everything compiles again. Will work to clean this all up and get all the tests to pass.

    * fix: `GF101` tests pass

    * fix: reimplement monty optimizations

    * clean: udeps

    ---------

    Co-authored-by: Waylon Jepsen <57912727+0xJepsen@users.noreply.github.com>

commit 96c8b66
Merge: fb27e5f 62a9a57
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Mon May 6 23:26:56 2024 +0000

    Merge pull request #42 from pluto/dependabot/cargo/anyhow-1.0.83

    Bump anyhow from 1.0.82 to 1.0.83

commit 62a9a57
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon May 6 23:26:43 2024 +0000

    Bump anyhow from 1.0.82 to 1.0.83

    Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.82 to 1.0.83.
    - [Release notes](https://github.com/dtolnay/anyhow/releases)
    - [Commits](dtolnay/anyhow@1.0.82...1.0.83)

    ---
    updated-dependencies:
    - dependency-name: anyhow
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
@github-actions github-actions bot mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xJepsen 0xJepsen 0xJepsen approved these changes

@devloper devloper Awaiting requested review from devloper

@thor314 thor314 Awaiting requested review from thor314

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Remove p3_field dependency
2 participants
@Autoparallel @0xJepsen