Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/dsl #60

Merged
merged 12 commits into from
Jul 1, 2024
Merged

Feat/dsl #60

merged 12 commits into from
Jul 1, 2024

Conversation

lonerapier
Copy link
Collaborator

@lonerapier lonerapier commented May 12, 2024

This PR fixes/closes issue #53

Very rough right now, don't review.

@lonerapier lonerapier linked an issue May 12, 2024 that may be closed by this pull request
@Autoparallel
Copy link
Contributor

This is lookin' pretty good. Would love to work with you on this as it seems like a crucial part of this project.

@lonerapier
Copy link
Collaborator Author

Sure @Autoparallel, will connect with you. This is currently a straight port of plonkathon's DSL compiler. Liked their approach a lot, so I didn't do any modifications yet.

Right now, adding tests and documentation. Would love your help as there's significant work still pending here.

@lonerapier lonerapier marked this pull request as ready for review May 15, 2024 20:59
@lonerapier
Copy link
Collaborator Author

@Autoparallel @0xJepsen PR is mostly done, will rebase on #63 and add scalar field when it's merged. Would love your review on this.

@Autoparallel
Copy link
Contributor

This is looking so good. I can give a passing review for sure, but I need to spend more time on this.

Let me wait until you merge in my other PR which just got merged into main now :)

@lonerapier
Copy link
Collaborator Author

@Autoparallel done

@lonerapier lonerapier mentioned this pull request May 20, 2024
Copy link
Contributor

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im down to merge this in nice work!

@lonerapier
Copy link
Collaborator Author

added a README with a walkthrough on how DSL is parsed and required polynomials are created.

If @Autoparallel doesn't have any suggestions, I think, we can merge this

@0xJepsen 0xJepsen merged commit 7549be8 into pluto:main Jul 1, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend for circuits
3 participants