feat: Tate pairing #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xJepsen
reviewed
May 16, 2024
0xJepsen
reviewed
May 16, 2024
0xJepsen
reviewed
May 17, 2024
| [PrimeField::<59>::ONE, PrimeField::<59>::ZERO, PrimeField::<59>::ONE]; | ||
| } | ||
|
|
||
| /// Returns the multiplication of two [`Ext<2, GF101>`] elements by reducing result modulo |
There was a problem hiding this comment.
This says GF101 but isn't it for Ext<2, GF59>?
0xJepsen
reviewed
May 17, 2024
src/curve/tests/fields.rs
Outdated
| /// Retrieves a multiplicative generator for GF(101) inside of [`Ext<2, GF101>`]. | ||
| /// This can be verified using sage script | ||
| /// ```sage | ||
| /// F = GF(101) |
There was a problem hiding this comment.
Should also be for GF59 right?
0xJepsen
reviewed
May 17, 2024
|
|
||
| // The curve is given by E: y^2 = x^3 + x over F_59. | ||
| // The curve has 60 points and we will take r = 5 to get a group in the 5-torsion called G. | ||
| // One generator for this group is P = (25,30) and we get: |
There was a problem hiding this comment.
Nice this is good documentation
0xJepsen
approved these changes
May 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the Tate pairing for our curves. Adds in a test case which comes from Lynn's thesis. Also added the ability to draw random points from our base curve.
Closes #56 ?