Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pool: fix dependencies with pmempool #5521

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

ldorau
Copy link
Member

@ldorau ldorau commented Jan 18, 2023

Fix dependencies with pmempool.
Not all tools that include 'src/tools/Makefile.inc' require linking with the common.o and output.o objects from pmempool. Only pmempool itself, ddmap, pmemobjcli, pmemspoil and pmemwrite tool require that.


This change is Reviewable

Fix dependencies with pmempool.
Not all tools that include 'src/tools/Makefile.inc'
require linking with the common.o and output.o objects
from pmempool. Only pmempool itself, ddmap, pmemobjcli,
pmemspoil and pmemwrite tool require that.
@ldorau ldorau force-pushed the pool-fix-dependencies-with-pmempool branch from a0b0dda to 72dc4a6 Compare January 18, 2023 10:17
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 6 files at r1.
Reviewable status: 4 of 6 files reviewed, all discussions resolved

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 4 of 6 files reviewed, all discussions resolved

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 6 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @ldorau)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ldorau)

Copy link
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ldorau)

@wlemkows wlemkows merged commit bba7717 into pmem:master Jan 18, 2023
@ldorau ldorau deleted the pool-fix-dependencies-with-pmempool branch January 19, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants