-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: disable pmem2_badblock tests due to #5636 #5650
Conversation
Codecov Report
@@ Coverage Diff @@
## stable-1.13 #5650 +/- ##
===============================================
+ Coverage 74.25% 74.27% +0.01%
===============================================
Files 145 145
Lines 22131 22131
Branches 3704 3705 +1
===============================================
+ Hits 16433 16437 +4
+ Misses 5698 5694 -4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @osalyk)
a discussion (no related file):
It is worth mentioning that it is a temporary solution.
src/test/pmem2_badblock/TESTS.py
line 73 at r1 (raw file):
# XXX - https://github.com/pmem/pmdk/issues/5636 class EX_TEST0(PMEM2_BADBLOCK_COUNT):
EX_ like exclude
or DISABLE_ like disable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @grom72 and @osalyk)
src/test/pmem2_badblock/TESTS.py
line 73 at r1 (raw file):
Previously, grom72 (Tomasz Gromadzki) wrote…
EX_ like exclude
or DISABLE_ like disable
EX is already taken by example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @osalyk)
a discussion (no related file):
Please rebase against stable.1.13
Temporary solution until a platform supporting the tested functionality is ready
1b93230
to
b41c2a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @grom72)
a discussion (no related file):
Previously, grom72 (Tomasz Gromadzki) wrote…
It is worth mentioning that it is a temporary solution.
Done.
a discussion (no related file):
Previously, grom72 (Tomasz Gromadzki) wrote…
Please rebase against stable.1.13
Done.
src/test/pmem2_badblock/TESTS.py
line 73 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
EX is already taken by example.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @osalyk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @osalyk)
This change is