.github: enable ndctl build

As --ndctl-build is on by default, the "real" way to enable ndctl is to
define $ndctl.

Add --ndctl-build anyway in case the default ever changes.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>

.github/workflows/main.yml

@@ -35,7 +35,7 @@ jobs:
             img_distro: ubuntu
             img_rel: noble
         arch: [x86_64]
-        run_opts: [--cxl]
+        run_opts: [--cxl --ndctl-build]
 
     steps:
       - uses: actions/checkout@v4
@@ -79,6 +79,13 @@ jobs:
           sudo apt install -y autoconf
           sudo make -C argbash-${AB_VER}/resources install PREFIX=/usr/local/
 
+      - name: download ndctl
+        uses: actions/checkout@v4
+        with:
+          repository: pmem/ndctl
+          ref: v80
+          path: ndctl
+
       - name: download kernel
         uses: actions/checkout@v4
         with:
@@ -105,6 +112,7 @@ jobs:
           mkosi --version
           cd kernel
           distro=${{ matrix.cfg.img_distro }} rev=${{ matrix.cfg.img_rel }} \
+                 ndctl='${{ github.workspace }}'/ndctl \
                  ../run_qemu/run_qemu.sh -v --no-run ${{ matrix.run_opts }}
 
       # TODO: drop --no-run thanks to "nested KVM" or something?

run_qemu.sh

@@ -938,7 +938,7 @@ prepare_ndctl_build()
 		mkosi.extra/root/ndctl/
 	cat <<- 'EOF' > mkosi.postinst
 		# v14: 'systemd-nspawn"; v15: "mkosi"
-		declare -p container || true
+		printf 'container=%s\n' "$container"
 		# .postinst and others moved outside container in mkosi v15, see
 		# https://github.com/systemd/mkosi/commit/9b626c647037bc8a
 		if [ -n "$container" ]; then