Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_qemu.sh: add some missing quotes #91

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Dec 18, 2024

This gets the total number of shellcheck warnings down from 22 to just 10.

Also: add a minor depmod comment. Use : instead of # so it shows when using --debug / set -x.

This gets the total number of shellcheck warnings down from 22 to just 10.

Also: add a minor depmod comment. Use : instead of # so it shows when
using --debug / set -x.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb marc-hb marked this pull request as ready for review December 18, 2024 19:01
@stellarhopper stellarhopper merged commit 8572fda into pmem:main Dec 18, 2024
2 checks passed
@marc-hb marc-hb deleted the missing-quotes branch December 18, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants