Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_qemu.sh: fix "readlink -f ~/git/ndctl" to: readlink -e #97

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Dec 22, 2024

-f is really weird and makes no sense here, it makes the build fail if ~/git exists and ~/git/ndctl does not.

man readlink

-f, --canonicalize
      canonicalize by following every symlink in  every  component  of  the
      given name recursively; all _but the last component_ must exist  ?!

-e, --canonicalize-existing
      canonicalize  by  following  every  symlink in every component of the
      given name recursively, all components must exist

-f is really weird and makes no sense here, it makes the build
fail if ~/git exists and ~/git/ndctl does not.

man readlink

-f, --canonicalize
      canonicalize by following every symlink in  every  component  of  the
      given name recursively; all _but the last component_ must exist  ?!

-e, --canonicalize-existing
      canonicalize  by  following  every  symlink in every component of the
      given name recursively, all components must exist

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb marc-hb marked this pull request as ready for review December 22, 2024 05:34
@marc-hb marc-hb merged commit a9d90eb into pmem:main Dec 22, 2024
2 checks passed
@marc-hb marc-hb deleted the readlink-e branch December 22, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant