Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useURLPolyfill doesn't seem to work in 0.5.0.rc-1 #444

Closed
tmeindle opened this issue Jul 7, 2021 · 4 comments · Fixed by #447
Closed

useURLPolyfill doesn't seem to work in 0.5.0.rc-1 #444

tmeindle opened this issue Jul 7, 2021 · 4 comments · Fixed by #447

Comments

@tmeindle
Copy link

tmeindle commented Jul 7, 2021

Hello,

I am unfortunately stuck supporting IE11 and have been having trouble with the overlay option.

If I set overlay: false I have no issues in IE11 apart from not having an error overlay. The page loads correctly and when I update a component the refresh happens.

However setting the overlay option to overlay: { useURLPolyfill: true} or overlay: { useURLPolyfill: false } results in an error in IE11 with the app crashing immediately with no render. Note everything works fine with Chrome and FF with any of the three settings.

This is the error in the dev tools
image

Best regards,
Tim

@tmeindle
Copy link
Author

tmeindle commented Jul 7, 2021

Actually I mistyped.. thought I was using the latest version and was wrong. The behavior I described before is in IE11 for 0.5.0-beta.9.

After updating to 0.5.0-rc.1 I can not get refresh to work in IE11 no matter what option I pass to the plugin.

"@pmmmwh/react-refresh-webpack-plugin": "0.5.0-rc.1",
"react-refresh": "0.11.0-alpha-ed6c091fe-20210701",  same behavior for 0.10.0
"webpack": "5.43.0",
"webpack-cli": "4.7.2",
"webpack-dev-server": "4.0.0-beta.3",

I get the following error:
image

@pmmmwh
Copy link
Owner

pmmmwh commented Jul 8, 2021

I'll check this. Unfortunately I do not have access to a machine with IE11 currently but I guess I can spawn a VM 😬

@pmmmwh
Copy link
Owner

pmmmwh commented Jul 11, 2021

Are you by any chance already using a polyfill in your app, like react-app-polyfill, and have the URL constructor polyfilled?

@tmeindle
Copy link
Author

tmeindle commented Jul 12, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants