Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatic DOM URL ponyfilling #278

Merged
merged 9 commits into from
Dec 24, 2020
Merged

feat: automatic DOM URL ponyfilling #278

merged 9 commits into from
Dec 24, 2020

Conversation

pmmmwh
Copy link
Owner

@pmmmwh pmmmwh commented Dec 16, 2020

This PR adds out of the box pony-filling capabilities for the DOM URL API.

@pmmmwh pmmmwh added the enhancement New feature or request label Dec 16, 2020
@pmmmwh pmmmwh self-assigned this Dec 16, 2020
@pmmmwh pmmmwh marked this pull request as ready for review December 24, 2020 19:34
@pmmmwh pmmmwh force-pushed the feat/url-integration branch from 03b2164 to 48d676b Compare December 24, 2020 19:35
@pmmmwh pmmmwh merged commit b49f832 into main Dec 24, 2020
@pmmmwh pmmmwh deleted the feat/url-integration branch December 24, 2020 20:10
@DinerIsmail
Copy link

Any chance you could release a new version that includes this fix please?

@pmmmwh
Copy link
Owner Author

pmmmwh commented Jan 12, 2021

Any chance you could release a new version that includes this fix please?

It is in 0.5.0 beta. If you need a stable version then you'll have to wait a bit since there are other stuff yet to be fixed.

@dineshpannu
Copy link

dineshpannu commented May 20, 2021

I'm trying this on IE 11 and can't get it to work.

The error is:

stack "TypeError: Unable to get property 'toLowerCase' of undefined or null reference\n at initWDSSocket (eval code:26:5)\n at setupOverlay (eval code:86:7)\n at runWithPatchedUrl (eval code:36:3)\n at eval code (eval code:82:4)\n at ../../node_modules/@pmmmwh/react-refresh-webpack-plugin/client/ErrorOverlayEntry.js?sockPort=8080&sockProtocol=http (http://192.168.0.120:8080/Content/JS/client.app.js:248:1)\n at options.factory (http://192.168.0.120:8080/Content/JS/client.app.js:6925:28)\n at webpack_require (http://192.168.0.120:8080/Content/JS/client.app.js:6410:48)\n at Anonymous function (http://192.168.0.120:8080/Content/JS/client.app.js:7490:26)\n at Anonymous function (http://192.168.0.120:8080/Content/JS/client.app.js:19:1)\n at webpackUniversalModuleDefinition (http://192.168.0.120:8080/Content/JS/client.app.js:17:3)"

Packages used:

  • react-refresh@0.10.0
  • @pmmmwh/react-refresh-webpack-plugin@0.5.0-beta.8
  • webpack@5.31.2
  • webpack-dev-server@3.11.2

Webpack config looks like (same outcome with or without overlay option):

    plugins: [
        new ReactRefreshWebpackPlugin({
            overlay: {
                useURLPolyfill: true // this is for IE 11
            }
        }),
    ],

@pmmmwh
Copy link
Owner Author

pmmmwh commented May 20, 2021

I didn't realise that there were nulls 😬 Will fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants