Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly throw when an ambiguous entry is received #320

Merged
merged 2 commits into from
Mar 1, 2021

Conversation

pmmmwh
Copy link
Owner

@pmmmwh pmmmwh commented Mar 1, 2021

This fixes issues where the plugin would silently fail when users are using zero-config Webpack setups (where we will receive an object in the format of { main: {} }). It will now throw and point the user to specify their entry object - so we do not need to do guess work on how to inject our entries.

Fixes #293
Fixes #303

@pmmmwh pmmmwh added the bug Something isn't working label Mar 1, 2021
@pmmmwh pmmmwh merged commit f2a2081 into main Mar 1, 2021
@pmmmwh pmmmwh deleted the fix/ambiguous-entry branch March 1, 2021 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant