Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client/Socket - ESM conversion #342

Merged
merged 12 commits into from
Apr 3, 2021

Conversation

pmmmwh
Copy link
Owner

@pmmmwh pmmmwh commented Apr 2, 2021

Since Webpack provides ESM-to-CJS module transforms, it makes strict-ESM a stricter syntax subset of the default auto/cjs modes. With that in mind, we can safely convert code that will be processed by Webpack to strict-ESM and it should run fine on both module systems.

@pmmmwh pmmmwh merged commit 6e35c67 into contextual-runtime/base Apr 3, 2021
@pmmmwh pmmmwh deleted the contextual-runtime/client branch April 3, 2021 00:20
@pmmmwh pmmmwh mentioned this pull request Apr 3, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant