Skip to content

Commit

Permalink
fix #990
Browse files Browse the repository at this point in the history
  • Loading branch information
@dktapps
dktapps committed Jun 3, 2017
1 parent 902957c commit 5baf59c
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/pocketmine/network/mcpe/protocol/AddEntityPacket.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ class AddEntityPacket extends DataPacket{
public $x;
public $y;
public $z;
public $speedX;
public $speedY;
public $speedZ;
public $speedX = 0.0;
public $speedY = 0.0;
public $speedZ = 0.0;
public $yaw = 0.0;
public $pitch = 0.0;
/** @var Attribute[] */
Expand Down

8 comments on commit 5baf59c

@MichaelM04
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dktapps You fixed this and the SetTitlePacket issue both things I was going to inform you about 😂 Only other issue I found was i had to declare "(int)" before $this->entityId in FloatingTextParticle::encode() on $this->entityRuntimeId .

@dktapps
Copy link
Member Author

@dktapps dktapps commented on 5baf59c Jun 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh for God's sake... I forgot about bcmath on that one -_- thanks

@RompeCraneos
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slapper still crashing...

@inxomnyaa
Copy link
Contributor

@inxomnyaa inxomnyaa commented on 5baf59c Jun 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dktapps thanks for fixing, came across the same issue. Wohoo, removing vars again from plugins, brb

@k3ithos
Copy link

@k3ithos k3ithos commented on 5baf59c Jun 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dktapps same changes required to AddPlayerPacket to fix SlapperHuman entities

@dktapps
Copy link
Member Author

@dktapps dktapps commented on 5baf59c Jun 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slapper was already updated.

@k3ithos
Copy link

@k3ithos k3ithos commented on 5baf59c Jun 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still required on AddPlayerPacket - Slapper doesn't declare speedX, speedY or speedZ which results in a server crash

@dktapps
Copy link
Member Author

@dktapps dktapps commented on 5baf59c Jun 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. makes sense.

Please sign in to comment.