-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Player quit crash - Human::getRawUniqueId() #1220
Comments
This and various other bugs occur when a player times out when trying to login. Likely someone attempted to join with an outdated client version. This causes the player to be closed with most of their fields not yet initialized due to LoginPacket not yet having been handled. |
This happens very often on my server, it crashes after about 5 minutes. Also, the error only occurs since I've updated PocketMine to cca9cf2. Unfortunately, I don't know on which commit I was before, but it shouldn't be more than 50 commits before this one. |
It was amongst the ALPHA7 changes. If you want a quick hack you could remove the string typehint from Human::getRawUniqueId(). |
crashdump tonight
|
This issue was fixed in 6ff92f2, however I'm leaving this open due to the wide range of potential other issues that could arise due to the current bad design. |
Hi, Is the bug fixed because today my server crashed with : PocketMine-MP_1.6.2dev-311_7d777510_API-3.0.0-ALPHA7.phar Critical Error : 2017-07-26 [13:09:17] �[Server thread/CRITICAL]: TypeError: "Return value of pocketmine\entity\Human::getRawUniqueId() must be of the type string, null returned" (EXCEPTION) in "src/pocketmine/entity/Human" at line 103� Plugins : Thanks |
Player and network really need to get divorced, and fast.
@gizanopatrica |
@dktapps Yes, apologies for that - I use my own fork in which I edited the version and support for any plugin API version... |
Issue description
Sometimes, when a player quits, the server crashes
Steps to reproduce the issue
OS and versions
Plugins
Reproducible on a server without plugins.
Crashdump, backtrace or other files
The text was updated successfully, but these errors were encountered: