Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forms API #1476

Closed
wants to merge 33 commits into from
Closed

Forms API #1476

wants to merge 33 commits into from

Commits on Oct 6, 2017

  1. Some base work for forms API

    @dktapps
    dktapps committed Oct 6, 2017
    1 Configuration menu
    Copy the full SHA
    96cba44 View commit details
    Browse the repository at this point in the history

  2. Implemented ListForm, refactored some stuff

    @dktapps
    dktapps committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    9f963dd View commit details
    Browse the repository at this point in the history

  3. fix inspections

    @dktapps
    dktapps committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    8ce7cb0 View commit details
    Browse the repository at this point in the history

  4. Change namespace to 'form' because @SOF3 is fussy

    @dktapps
    dktapps committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    8f40482 View commit details
    Browse the repository at this point in the history

  5. Move "title" property up to Form base class 

    all forms have titles
    @dktapps
    dktapps committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    383cb7c View commit details
    Browse the repository at this point in the history

  6. ModalForm: fix typo

    @dktapps
    dktapps committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    d0690b8 View commit details
    Browse the repository at this point in the history

  7. Added some documentation

    @dktapps
    dktapps committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    fa7eadb View commit details
    Browse the repository at this point in the history

  8. Some changes to how response data is handled to make it consistent ac… 

    …ross the board
    @dktapps
    dktapps committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    ecd51b2 View commit details
    Browse the repository at this point in the history

  9. Refactor ListForm -> MenuForm and Button -> MenuOption 

    this makes it completely clear what both of these do, and also makes it clear that buttons can't be put on custom forms.
    @dktapps
    dktapps committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    ca107a6 View commit details
    Browse the repository at this point in the history

  10. Added CustomForm and its components

    @dktapps
    dktapps committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    5b84b43 View commit details
    Browse the repository at this point in the history

  11. Added ServerSettingsForm class, refactor icon handling

    @dktapps
    dktapps committed Oct 6, 2017
    Configuration menu
    Copy the full SHA
    a7df2ca View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2017

  1. fix some issues

    @dktapps
    dktapps committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    4877f96 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2017

  1. don't allow re-using form objects

    @dktapps
    dktapps committed Oct 21, 2017
    Configuration menu
    Copy the full SHA
    a0a9eb9 View commit details
    Browse the repository at this point in the history

  2. refactor some confusing shit

    @dktapps
    dktapps committed Oct 21, 2017
    Configuration menu
    Copy the full SHA
    04965a1 View commit details
    Browse the repository at this point in the history

  3. change some exception messages to be more clear

    @dktapps
    dktapps committed Oct 21, 2017
    Configuration menu
    Copy the full SHA
    17ad96f View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2017

  1. Implemented form queuing

    @SOF3
    SOF3 committed Oct 23, 2017
    Configuration menu
    Copy the full SHA
    66b854d View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2017

  1. Changed the argument order of some constructors

    @SOF3
    SOF3 committed Nov 11, 2017
    Configuration menu
    Copy the full SHA
    f87b23b View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2017

  1. Merge branch 'master' into forms-api

    @dktapps
    dktapps committed Nov 12, 2017
    Configuration menu
    Copy the full SHA
    9c72600 View commit details
    Browse the repository at this point in the history

  2. fixed returning forms

    @dktapps
    dktapps committed Nov 12, 2017
    1 Configuration menu
    Copy the full SHA
    cd5667c View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2017

  1. Fixed client barfing on forms when assoc arrays are used

    @dktapps
    dktapps committed Nov 22, 2017
    Configuration menu
    Copy the full SHA
    e4c409a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into forms-api

    @dktapps
    dktapps committed Nov 22, 2017
    Configuration menu
    Copy the full SHA
    845c3fc View commit details
    Browse the repository at this point in the history

  3. add constant visibility

    @dktapps
    dktapps committed Nov 22, 2017
    Configuration menu
    Copy the full SHA
    3b6ac5f View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2017

  1. Merge branch 'master' into forms-api

    @dktapps
    dktapps committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    a449406 View commit details
    Browse the repository at this point in the history

  2. Change hasBeenQueued() to isInUse()

    @dktapps
    dktapps committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    6d5e8ad View commit details
    Browse the repository at this point in the history

  3. Fixed returning $this in onSubmit() or onClose()

    @dktapps
    dktapps committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    7a916fd View commit details
    Browse the repository at this point in the history

  4. add some phpdoc

    @dktapps
    dktapps committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    1ab98db View commit details
    Browse the repository at this point in the history

  5. Revert "Fixed returning $this in onSubmit() or onClose()" 

    This reverts commit 7a916fd.
    @dktapps
    dktapps committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    5f8599a View commit details
    Browse the repository at this point in the history

  6. Fixed returning already-used forms, rev. 2

    @dktapps
    dktapps committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    a835179 View commit details
    Browse the repository at this point in the history

  7. Beware exception throws messing up the queue

    @dktapps
    dktapps committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    5a76b34 View commit details
    Browse the repository at this point in the history

  8. Don't block the player, it didn't do anything wrong

    @dktapps
    dktapps committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    dfdafd2 View commit details
    Browse the repository at this point in the history

  9. Don't break the form queue when DataPacketSendEvent is cancelled

    @dktapps
    dktapps committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    b0f00b0 View commit details
    Browse the repository at this point in the history

  10. Added debug for form ID mismatch

    @dktapps
    dktapps committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    402acf5 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2018

  1. Merge branch 'master' into forms-api

    @dktapps
    dktapps committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    eadc44d View commit details
    Browse the repository at this point in the history