Allowed players to eat in creative mode and difficulty peaceful #5923
Conversation
|
Not a fan of the signature changes here. I think this should be doable without API changes. |
|
By the way, how to automatically delete the use path when not using (e.g: use pocketmine\entity\Consumable;) in PhpStorm? |
src/player/Player.php
Outdated
| @@ -673,6 +673,10 @@ public function setUsingItem(bool $value) : void{ | |||
| $this->networkPropertiesDirty = true; | |||
| } | |||
|
|
|||
| public function allowForceEating () : bool{ | |||
There was a problem hiding this comment.
I'm not a fan of this name. It feels way too specific.
There was a problem hiding this comment.
I'm not a fan of this name. It feels way too specific.
what is your idea?
There was a problem hiding this comment.
canPlayerConsume
canPlayerSnack
canPlayerChew
canPlayerDevour
isPlayerFamished
allowForceFeast
canFreelyEating
There was a problem hiding this comment.
Could canEatAnytime better ? It can't include player because it's linked to Human and not only Player.
There was a problem hiding this comment.
None of these address my original comment.
I'm thinking more along the lines of canEat(), which covers the creative case and hunger together.
There was a problem hiding this comment.
canEat() seems too general, but I too go with that.
There was a problem hiding this comment.
@ShockedPlot7560 Can I go with "canEatWithoutHunger"?
Co-authored-by: ShockedPlot7560 <no-reply@tchallon.fr>
ShockedPlot7560
added
the
Type: Enhancement
Introduction
Allowed players to eat in creative mode and difficulty peaceful.
Player::allowForceEating().Backwards compatibility
Maybe?
Tests
Dang.ghi.2023-07-20.225517.mp4