Blockstate schema generator improvements #6416
Open
+249
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… new ID this allows more compaction in certain cases, such as tallgrass recently. instead of blacklisting any mapping which reuses the same flattened infix, we select the flatten property which produces the smallest number of distinct rules, which produces the most compact schema possible. this change also permits potentially flattening other types of properties such as for corals (live/dead and type), although only one may be selected at a time.
this allows optimisation in upcoming versions.
this issue can be worked around by adding a dummy schema, but it's a bit clunky.
…ting them this is useful when making changes to the generator, since regenerated schemas can now be tested for validity. This helps to find bugs in the generator.
…s to a newer format this is useful when the generator was updated with new features & optimisations, to reduce the size and/or improve readability of existing schemas.
dktapps
added
Type: Enhancement
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ma-generator-improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR adds a variety of improvements to the blockstate schema generator tool.
This mostly involves adding some utilities that I had locally for a while, and some minor improvements highlighted by 1.21.20.
Since I'm the only one with enough knowledge to do useful work on this tool, I decided to do this pro bono. Don't get excited, I'm not returning to active development.
flattenedValueRemaps), useful for 1.21.20No backwards-incompatible changes were made, so old schemas will continue to work unchanged. Please see individual commits for specific changes.
Tests
Locally tested with 1.21.20 data supplied by @TwistedAsylumMC. Team members are advised to play with this tool to get familiar with it.