Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #823 #825

Merged
merged 1 commit into from
Apr 14, 2017
Merged

Fix #823 #825

merged 1 commit into from
Apr 14, 2017

Conversation

Muqsit
Copy link
Contributor

@Muqsit Muqsit commented Apr 13, 2017

This pull request fixes the glitchy behaviour of titles.
Sending the subtitle packet first seems to solve the issue.

Thanks to @SuperMaXAleX

Thanks to @SuperMaXAleX
@dktapps dktapps self-requested a review April 13, 2017 19:35
@dktapps dktapps added Category: Gameplay Related to Minecraft gameplay experience Category: API Related to the plugin API Type: Fix Bug fix, typo fix, or any other fix labels Apr 13, 2017
@dktapps
Copy link
Member

dktapps commented Apr 13, 2017

Looks good, however I can't test this immediately, I'll do that tomorrow. If I manage to forget about it for a few days, feel free to bump the PR to remind me.

Copy link
Contributor

@buchwasa buchwasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm for me!

@moskadev
Copy link
Contributor

Happy to know :D

@dktapps dktapps merged commit 40775f5 into pmmp:api3/network Apr 14, 2017
@dktapps dktapps removed their request for review April 14, 2017 09:42
@Muqsit Muqsit deleted the api3/network branch April 14, 2017 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: API Related to the plugin API Category: Gameplay Related to Minecraft gameplay experience Type: Fix Bug fix, typo fix, or any other fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants