Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some regulations... #222

Closed
wants to merge 8 commits into from
Closed

Some regulations... #222

wants to merge 8 commits into from

Conversation

ismaileke
Copy link

No description provided.

Unused local variable 'sessionId'. The value of the variable is not used anywhere.
Argument type does not match the declared
'if' statement with common parts
Add 'int' as the function's return type
Missing 'void' return type
missing 'int' type
Copy link

@JavierLeon9966 JavierLeon9966 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to pass the PHPStan checks

@dktapps
Copy link
Member

dktapps commented Nov 7, 2023

This PR is trying to change too many different things at once. Please submit the changes separately.

@dktapps dktapps closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants