fix: Splat remove unused vars, storybook cam fix (#49)

pmndrs · Dec 5, 2023 · b9d0dfa · b9d0dfa
1 parent 9ace203
commit b9d0dfa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/.storybook/stories/Splat.stories.ts b/.storybook/stories/Splat.stories.ts
@@ -17,12 +17,11 @@ export const SplatStory = async () => {
 
   const controls = new OrbitControls(camera, renderer.domElement)
   controls.target.set(0, 1, 0)
+  camera.position.set(10, 10, 10)
   controls.update()
 
   scene.background = new THREE.Color('white')
 
-  camera.position.set(10, 10, 10)
-
   loadSplats(renderer, camera, scene)
 }
 

diff --git a/src/core/Splat.ts b/src/core/Splat.ts
@@ -616,14 +616,9 @@ function pushDataBuffer(shared: SharedState, buffer: ArrayBufferLike, vertexCoun
 }
 
 export class Splat extends THREE.Mesh {
-  camera: THREE.Camera
-  shared: any
-  alphaHash: boolean
   constructor(shared: any, camera: THREE.Camera, { toneMapped = false, alphaTest = 0, alphaHash = false } = {}) {
     super()
-    this.shared = shared
-    this.camera = camera
-    this.alphaHash = alphaHash
+
     this.frustumCulled = false
     this.onBeforeRender = () => shared.update(this, camera, alphaHash)
     this.material = new SplatMaterial()
@@ -641,8 +636,4 @@ export class Splat extends THREE.Mesh {
     })
     shared.connect(this)
   }
-
-  splatUpdate() {
-    this.shared.update(this, this.camera, this.alphaHash)
-  }
 }