Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introducing Text #37

Merged
merged 7 commits into from
Sep 10, 2023
Merged

feat: introducing Text #37

merged 7 commits into from
Sep 10, 2023

Conversation

alexzhang1030
Copy link
Contributor

Why

Port the Text component of @pmndrs/drei

What

Checklist

  • Documentation updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 8, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 038dfde:

Sandbox Source
white-cloud-d5t64x Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@vis-prime
Copy link
Collaborator

isn't it better to use https://www.npmjs.com/package/troika-three-text directly ?

also add the troika dependency in peerDependencies so that you don't need the exact version

 "peerDependencies": {
    "three": ">=0.137"
  }

@alexzhang1030
Copy link
Contributor Author

isn't it better to use npmjs.com/package/troika-three-text directly ?

also add the troika dependency in peerDependencies so that you don't need the exact version

 "peerDependencies": {
    "three": ">=0.137"
  }

Done! And I replaced the Billboard story with the Text & Billboard story.

I think we wrapped the troika-three-text as our component same with pmndrs/drei will reduce the complexity of adding text, devs do not need to read the docs of troika-three-text.

@vis-prime vis-prime merged commit 7858fb0 into pmndrs:main Sep 10, 2023
@github-actions
Copy link

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@alexzhang1030 alexzhang1030 deleted the feat/text branch September 10, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants