Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Controls can now receive a custom camera as prop #321

Merged
merged 2 commits into from
Mar 6, 2021
Merged

feat: Controls can now receive a custom camera as prop #321

merged 2 commits into from
Mar 6, 2021

Conversation

gsimone
Copy link
Member

@gsimone gsimone commented Mar 6, 2021 •
edited
Loading

@vercel
Copy link

vercel bot commented Mar 6, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/drei/54Ru4uYMiveWufLX7Ki8d6aarEgG
✅ Preview: https://drei-git-feature-custom-camera-for-controls-pmndrs.vercel.app

@gsimone
Copy link
Member Author

gsimone commented Mar 6, 2021

Making stories for each control type would have been super time consuming and a lot of boilerplate code. If anybody wants to do that in the future, cool, but they are not really necessary.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 6, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 56a170c:

Sandbox Source
eager-cori-t60k8 Configuration
drei reflector Configuration
arc-x-pmndrs-colors Configuration
r3f⚡ multi-view PR

@gsimone gsimone requested review from joshuaellis, drcmda and emmelleppi and removed request for joshuaellis March 6, 2021 11:38
joshuaellis
joshuaellis approved these changes Mar 6, 2021
View reviewed changes
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 LGTM

@joshuaellis joshuaellis merged commit e494021 into master Mar 6, 2021
@joshuaellis joshuaellis mentioned this pull request Mar 6, 2021
Closed
@gsimone gsimone deleted the feature/custom-camera-for-controls branch March 6, 2021 13:56
@github-actions
Copy link

github-actions bot commented Mar 6, 2021

🎉 This PR is included in version 3.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 4.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released on @beta released in beta for review label Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

@drcmda drcmda Awaiting requested review from drcmda

@emmelleppi emmelleppi Awaiting requested review from emmelleppi

Assignees
No one assigned
Labels
released on @beta released in beta for review released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsimone @joshuaellis