Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text sync invalidate #100

Merged
merged 2 commits into from
Aug 26, 2020
Merged

Text sync invalidate #100

merged 2 commits into from
Aug 26, 2020

Conversation

giulioz
Copy link
Member

@giulioz giulioz commented Aug 26, 2020 •
edited
Loading

Closes #99

@giulioz giulioz requested a review from gsimone August 26, 2020 08:50
stephencorwin
stephencorwin approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@stephencorwin stephencorwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any negative implications to this? If not, feel free to merge.

@giulioz
Copy link
Member Author

giulioz commented Aug 26, 2020

Not to my knowledge

@giulioz giulioz merged commit d5d6827 into pmndrs:master Aug 26, 2020
@giulioz giulioz deleted the text-sync-invalidate branch August 26, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephencorwin stephencorwin stephencorwin approved these changes

@gsimone gsimone Awaiting requested review from gsimone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invalidateFrameLoop with drei Text
2 participants
@giulioz @stephencorwin