Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CycleRaycast): raycast keycode #1693

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

roprgm
Copy link
Contributor

@roprgm roprgm commented Oct 20, 2023

Why

CycleRaycast keyCode is not working because event.keyCode is always true.

What

Fixed by adding parentheses on the condition

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 1:24am

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3433da6:

Sandbox Source
intelligent-brahmagupta-4q9ls7 Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@CodyJasonBennett CodyJasonBennett changed the title fix: cycle raycast keycode fix(CycleRaycast): raycast keycode Oct 27, 2023
@drcmda drcmda merged commit c000f72 into pmndrs:master Nov 15, 2023
4 checks passed
Copy link

🎉 This PR is included in version 9.88.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants