Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove problematic Object3D generic #1696

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

Methuselah96
Copy link
Contributor

Why

The current types cause errors for @types/three@0.156.0 and above because the Object3D generic is no longer just an event type:

Error: node_modules/@react-three/drei/core/MotionPathControls.d.ts(6,50): error TS2344: Type 'Event<string, unknown>' does not satisfy the constraint 'Object3DEventMap'.
  Type 'Event<string, unknown>' is missing the following properties from type 'Object3DEventMap': added, removed
Error: node_modules/@react-three/drei/core/MotionPathControls.d.ts(7,51): error TS2344: Type 'Event<string, unknown>' does not satisfy the constraint 'Object3DEventMap'.

What

Remove the unnecessary specified generic.

Checklist

  • Documentation updated (example)
  • Storybook entry added (example)
  • Ready to be merged

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 9:04pm

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a4ceed4:

Sandbox Source
elated-swirles-8s8qnp Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@github-actions
Copy link

🎉 This PR is included in version 9.88.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Methuselah96 Methuselah96 deleted the fix-object-generic branch October 25, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants