fix: round up framesH and framesV calc to solve visual shake in SpriteAnimator #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
@juniorxsound thank you for your contribution! |
|
🎉 This PR is included in version 9.102.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(👋 first time contributor here, just wanted to say thank you for all your work)
Why
Using SpriteAnimator (most noticeable with large) spritesheets sometimes results in sprite shaking. Looked at why that happens (at first was thinking sprite texture filtering...etc) it seems the
framesHandframesVcalculations have small precision issues which result in visual shake in the sprite as it's playing (since it's use to calculate the texture offsets). Simply rounding them solves the visual shake .Here is a small Codesandbox reproduction of the issue (Sandbox / Demo)
And here is a quick sandbox implementing the fix (Sandbox / Demo)
What
framesHandframesVinMath.round(since they can be suffer from decimal precision instability which makes the sprite shake)Checklist